Feat: Cloud connections #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuul-wq
commented
Jul 26, 2024
| '0xb0a8d493285c2df73290dfb7e61f870f17b41801197a149ca93654499ea3dafe': true, // KUSAMA | ||
| '0x68d56f15f85d3136970ec16946040bc1752654e906147f7e43e9d539d7c3de2f': true, // DOT_ASSET_HUB | ||
| '0xe143f23803ac50e8f6f8e62695d1ce9e4e1d68aa36c1cd2cfd15340213f3423e': true, // WESTEND | ||
| export const DEFAULT_CONNECTED_CHAINS: Record<ChainId, AssetId[]> = { |
There was a problem hiding this comment.
In case we have more than one asset to connect
tuul-wq
commented
Jul 26, 2024
| expect(scope.getState(networkModel._internal.$chains)).toEqual(mockedChainsMap); | ||
| }); | ||
|
|
||
| test('should add metadata subscription after createProviderFx effect', async () => { |
There was a problem hiding this comment.
Pretty useless test
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
tuul-wq
commented
Jul 26, 2024
| await allSettled(networkModel._internal.requestMetadataFx, { scope, params: {} as ApiPromise }); | ||
|
|
||
| expect(scope.getState(networkModel._internal.$metadata)).toEqual([mockMetadata]); | ||
| }); | ||
|
|
||
| test('should connect to default_chains on networkStarted event', async () => { | ||
| const scope = fork(); | ||
| vi.spyOn(chainsApi, 'getChainsData').mockResolvedValue(mockedChains); |
There was a problem hiding this comment.
Mock API in order to make sure effect logic works as intended
tuul-wq
commented
Jul 26, 2024
| @@ -173,16 +182,30 @@ sample({ | |||
| }); | |||
|
|
|||
| sample({ | |||
| clock: combineEvents([populateChainsFx.doneData, getConnectedAssetsFx.doneData]), | |||
| clock: requestChainsFx.doneData, | |||
There was a problem hiding this comment.
Connect default chains as soon as they come, not waiting for CloudStorage
johnthecat
approved these changes
Jul 29, 2024
sokolova-an
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
= Task =